Semconv codegen should produce different constant names if attribute is renamed _
-> ``
#3927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code generator generates the same attribute name constant for
attribute.name
andattribute_name
. As a result, if attribute is renamed (_
is changed to.
or vice versa), the value of attribute changes, but the name stays the same.It's ambiguous - see open-telemetry/semantic-conventions#1031 and open-telemetry/semantic-conventions#1118 for the discussion.
Based on open-telemetry/semantic-conventions#1118, the semconv recommendation would be to:
_
when generating any constants in the code (fields, methods, class names, etc)_
This PR demonstrates the result of such naming policy change.
Type of change
Please delete options that are not relevant.
Checklist: