-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to_json method to ExponentialHistogram #3780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a test while you are at it
I did not find a good existing place for exporter tests. Would a console exporter's integration test suffice? |
@xrmx is it changelog worthy, or should we just add "Skip Changelog"? |
Since this is user visible I think it'll be good to have it recorded in the Changelog |
fa9c696
to
4aecf46
Compare
@xrmx can you please kick off the tests? |
Sorry, I don't have enough powers |
@pmcollins when you have a second, can you please kick off the tests, and maybe merge if it looks good? |
@pmcollins can you please add the "Skip Public API check" label? Currently the check thinks that:
even though i did not touch that code. |
opentelemetry-sdk/tests/metrics/integration_test/test_console_exporter.py
Outdated
Show resolved
Hide resolved
60c7f76
to
61ebe89
Compare
@pmcollins a friendly ping =) (and maybe @srikanthccv) |
Thank you for your patience :). Can you fix lint @rbtz-openai ? |
7ecc0df
to
3f67ec9
Compare
Updated, now it passes:
But, sadly, fails |
Nice. That failure appears to be unrelated -- we'll have to chase it down separately. |
Description
This fixes console exporter for ExponentialHistogram.
Fixes #3579
Type of change
Does This PR Require a Contrib Repo Change?
Checklist: