Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.12 deprecation warning #3751

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

jenshnielsen
Copy link
Contributor

@jenshnielsen jenshnielsen commented Mar 5, 2024

Description

utcfromtimestamp is deprecated replace
with fromtimestamp with explict UTC timezone

See https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This is a simple bug fix to an existing line that is already tested

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added N/A
  • Documentation has been updated N/A

@jenshnielsen jenshnielsen requested a review from a team March 5, 2024 12:49
@jenshnielsen jenshnielsen force-pushed the datetime_deprecation branch from d9bfb67 to f1ad811 Compare March 5, 2024 13:17
@ocelotl ocelotl merged commit 8ad10f7 into open-telemetry:main Mar 7, 2024
232 checks passed
@jenshnielsen jenshnielsen deleted the datetime_deprecation branch March 7, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants