Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type annotation for protobuf serialized data #3699

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

methane
Copy link
Contributor

@methane methane commented Feb 22, 2024

Description

Message.SerializeToString() returns bytes despite its name.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e mypy

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@methane methane requested a review from a team February 22, 2024 13:48
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 29, 2024
@ocelotl ocelotl enabled auto-merge (squash) February 29, 2024 02:59
auto-merge was automatically disabled February 29, 2024 03:05

Pull Request is not mergeable

@ocelotl ocelotl enabled auto-merge (squash) February 29, 2024 03:37
@ocelotl ocelotl merged commit d01dbc2 into open-telemetry:main Feb 29, 2024
232 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants