Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tox #3624

Merged
merged 14 commits into from
Feb 14, 2024
Merged

Upgrade tox #3624

merged 14 commits into from
Feb 14, 2024

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Jan 7, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tox 4 changed how quotes are handled (tox-dev/tox#845). I removed quotes and escaped the #.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • CI should pass
  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@iurisilvio iurisilvio requested a review from a team January 7, 2024 10:01
@iurisilvio iurisilvio marked this pull request as draft January 7, 2024 10:29
@iurisilvio iurisilvio force-pushed the upgrade-tox branch 3 times, most recently from a6eac1b to fdcd75d Compare January 7, 2024 12:20
@iurisilvio iurisilvio marked this pull request as ready for review January 7, 2024 12:54
@srikanthccv
Copy link
Member

We are removing 3.7 support here #3668, let's wait and rebase this post that PR merge to main.

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 13, 2024
@ocelotl ocelotl merged commit 55bf100 into open-telemetry:main Feb 14, 2024
232 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
3 participants