Allow bytes as attributes

[adriangb]

#3596 (reply in thread)

cc @srikanthccv

[srikanthccv]

We also need to update the exporter(s) code to support the bytes encoding. For instance, here for OTLP

opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py

Lines 62 to 81 in da48e0b

	def _encode_value(value: Any) -> PB2AnyValue:
	if isinstance(value, bool):
	return PB2AnyValue(bool_value=value)
	if isinstance(value, str):
	return PB2AnyValue(string_value=value)
	if isinstance(value, int):
	return PB2AnyValue(int_value=value)
	if isinstance(value, float):
	return PB2AnyValue(double_value=value)
	if isinstance(value, Sequence):
	return PB2AnyValue(
	array_value=PB2ArrayValue(values=[_encode_value(v) for v in value])
	)
	elif isinstance(value, Mapping):
	return PB2AnyValue(
	kvlist_value=PB2KeyValueList(
	values=[_encode_key_value(str(k), v) for k, v in value.items()]
	)
	)
	raise Exception(f"Invalid type {type(value)} of value {value}")

[adriangb]

Handled that case but I don't immediately see any others. Can you point them to me? Or can we just leave them as is and fix them as requested?

[srikanthccv]

Let's encode to bytes as strings if the exporter/protocol doesn't support bytes.

• OpenCensus doesn't support bytes. Lets encode as a string here
• OTLP ✅
• Prometheus values must be strings. Should be modified here
• Zipkin only supports strings. Conversion here