-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTLPMetricExporter ignores preferred_aggregation property #3603
Merged
ocelotl
merged 20 commits into
open-telemetry:main
from
Dudssource:fix-otlpexporter-preferred-aggregation
Feb 14, 2024
Merged
Fix OTLPMetricExporter ignores preferred_aggregation property #3603
ocelotl
merged 20 commits into
open-telemetry:main
from
Dudssource:fix-otlpexporter-preferred-aggregation
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
changed the title
Fix #3522 OTLPMetricExporter ignores preferred_aggregation property
Fix OTLPMetricExporter ignores preferred_aggregation property
Dec 31, 2023
Let's add a unit test and CHANGELOG entry |
Dudssource
added a commit
to Dudssource/opentelemetry-python
that referenced
this pull request
Jan 8, 2024
Thanks @srikanthccv for your feedback! |
pmcollins
reviewed
Jan 10, 2024
...to-common/src/opentelemetry/exporter/otlp/proto/common/_internal/metrics_encoder/__init__.py
Outdated
Show resolved
Hide resolved
pmcollins
reviewed
Jan 16, 2024
...to-common/src/opentelemetry/exporter/otlp/proto/common/_internal/metrics_encoder/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
Jan 20, 2024
...orter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
previously approved these changes
Jan 22, 2024
...to-common/src/opentelemetry/exporter/otlp/proto/common/_internal/metrics_encoder/__init__.py
Outdated
Show resolved
Hide resolved
Linter is now passing (0195013) |
Pylint linter fixed on d60819a |
ocelotl
force-pushed
the
fix-otlpexporter-preferred-aggregation
branch
from
February 13, 2024 23:32
967521a
to
af1de86
Compare
ocelotl
pushed a commit
to Dudssource/opentelemetry-python
that referenced
this pull request
Feb 13, 2024
…e _common_configuration function
…tion, to avoid possible problems with linters
ocelotl
force-pushed
the
fix-otlpexporter-preferred-aggregation
branch
from
February 13, 2024 23:43
ba8cd42
to
479e28e
Compare
ocelotl
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OTLPMetricExporter was ignoring the
preferred_aggregation
property, not allowing any kind of customization directly on the constructor.Fixes #3522
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
ExplicitBucketHistogramAggregation
)I've tried the following configuration for my MetricReader:
On my OTLP collector (localhost:4318), I configured the logging exporter for metrics:
After this setup, I was able to see my histograms being exported with my explicit configured boundaries.
Before (without the fix):
After (with the fix):
Does This PR Require a Contrib Repo Change?
Checklist: