Add annotation to slower tests so devs can skip them #3491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to close this for now -- instead will open a PR shortly to make the tests faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change registers an annotation to mark any test method as 'slow'. It also annotates test methods that take roughly a full second or longer.
After this change, if you want to run tests but skip the slower ones, you can use
-m 'not slow', as intox -- -m 'not slow'orpytest -m 'not slow'. The slow marker may also be useful to developers running individual test methods manually (one of the test methods annotated in this PR, for example, takes several minutes on my machine).However, by default, there is no intended change in behavior as a result of this PR -- all tests should still run locally and in CI by default.