-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BoundedAttributes instead of raw dict to extract attributes from LogRecord #3114 #3310
Merged
ocelotl
merged 26 commits into
open-telemetry:main
from
nstawski:ns-3114-bounded-attributes-insteadof-dict-LogRecord
May 24, 2023
Merged
Use BoundedAttributes instead of raw dict to extract attributes from LogRecord #3114 #3310
ocelotl
merged 26 commits into
open-telemetry:main
from
nstawski:ns-3114-bounded-attributes-insteadof-dict-LogRecord
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… init, so it would still work if the record is instantiated directly
…e BoundedAttributes is not serializable
Co-authored-by: Diego Hurtado <[email protected]>
…steadof-dict-LogRecord
Looks good, please add a test case ✌️ |
@ocelotl done. |
srikanthccv
reviewed
May 16, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
srikanthccv
reviewed
May 19, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
May 19, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
May 19, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
May 19, 2023
ocelotl
reviewed
May 19, 2023
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
reviewed
May 19, 2023
srikanthccv
approved these changes
May 22, 2023
nstawski
force-pushed
the
ns-3114-bounded-attributes-insteadof-dict-LogRecord
branch
from
May 23, 2023 04:31
417b300
to
93beb55
Compare
shalevr
reviewed
May 23, 2023
shalevr
approved these changes
May 23, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using BoundedAttributes instead of a simple dict in LogRecord; Updated the
_to_json
function soattributes
behave the same way as before the conversion, and tests pass.I made a change in
LogRecord
itself and not in_get_attributes
so that if someone instantiates it directly, BoundedAttributes would still be used.This ticket also incorporates changes for Support dropped_attributes_count in LogRecord (#3201)
Fixes #3114 and #3201
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
[] Yes. - Link to PR:
No.
Checklist: