Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra whitespace from tox.ini #3236

Merged
merged 16 commits into from
Mar 28, 2023
Merged

Remove extra whitespace from tox.ini #3236

merged 16 commits into from
Mar 28, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Mar 24, 2023

Fixes #3235

@ocelotl ocelotl requested a review from a team March 24, 2023 15:07
@ocelotl ocelotl marked this pull request as draft March 24, 2023 15:07
@ocelotl ocelotl self-assigned this Mar 24, 2023
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 24, 2023
@ocelotl ocelotl force-pushed the issue_3235 branch 2 times, most recently from b5201fe to f626586 Compare March 28, 2023 01:49
@ocelotl ocelotl changed the title WIP Enable Git tracing in tox.ini Mar 28, 2023
@ocelotl ocelotl marked this pull request as ready for review March 28, 2023 02:14
@srikanthccv srikanthccv enabled auto-merge (squash) March 28, 2023 06:13
aabmass
aabmass reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocelotl did you try bumping the cache keys in the workflow yamls?

tox.ini Outdated Show resolved Hide resolved
lzchen
lzchen approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocelotl
Let's treat this as a temporary workaround? Especially because we are not able to pinpoint the exact cause.

@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 28, 2023

@ocelotl did you try bumping the cache keys in the workflow yamls?

Not yet, trying that.

@ocelotl ocelotl changed the title Enable Git tracing in tox.ini Remove extra whitespace from tox.ini Mar 28, 2023
@srikanthccv srikanthccv merged commit b30b935 into open-telemetry:main Mar 28, 2023
@ocelotl ocelotl deleted the issue_3235 branch March 28, 2023 17:52
@srikanthccv
Copy link
Member

Haha, did it work itself without bumping cache keys?

@ocelotl ocelotl mentioned this pull request Mar 28, 2023
Closed
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 28, 2023

Haha, did it work itself without bumping cache keys?

Any change to tox.ini updates the cache (thanks @aabmass for pointing that out). So, that seems to be the reason why any change I added to tox.ini "fixed" the problem.

Another thing that suggests this was cache-related is the fact that first both getting-started environments for Windows and Ubuntu were failing but after a few days only the Windows ones were failing. Maybe the cache does not get updated at the same time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass left review comments

@shalevr shalevr shalevr approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI is failing
5 participants
@ocelotl @srikanthccv @aabmass @lzchen @shalevr