Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate jaeger exporters #3158

Merged
merged 9 commits into from
Feb 13, 2023
Merged

deprecate jaeger exporters #3158

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f0768e9
deprecate jaeger exporters
srikanthccv Feb 4, 2023
324d0ed
correct version
srikanthccv Feb 4, 2023
bb090c4
Add CHANGELOG entry
srikanthccv Feb 4, 2023
8d2ba6a
Merge branch 'main' into deprecate-jaeger
lzchen Feb 6, 2023
73fef5b
Add deprecation message to README
srikanthccv Feb 11, 2023
46acb61
Merge branch 'deprecate-jaeger' of github.com:srikanthccv/opentelemet…
srikanthccv Feb 11, 2023
2d16335
Merge branch 'main' into deprecate-jaeger
srikanthccv Feb 13, 2023
f1ef631
Merge branch 'main' into deprecate-jaeger
srikanthccv Feb 13, 2023
1a07637
Merge branch 'main' into deprecate-jaeger
ocelotl Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3151](https://github.com/open-telemetry/opentelemetry-python/pull/3151))
- Bump min required api version for OTLP exporters
([#3156](https://github.com/open-telemetry/opentelemetry-python/pull/3156))
- deprecate jaeger exporters
([#3158](https://github.com/open-telemetry/opentelemetry-python/pull/3158))

## Version 1.15.0/0.36b0 (2022-12-09)

Expand Down
5 changes: 5 additions & 0 deletions ...metry-exporter-jaeger-proto-grpc/src/opentelemetry/exporter/jaeger/proto/grpc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
import logging
from os import environ
from typing import Optional
from deprecated import deprecated

from grpc import ChannelCredentials, RpcError, insecure_channel, secure_channel

Expand Down Expand Up @@ -110,6 +111,10 @@ class JaegerExporter(SpanExporter):
timeout: Maximum time the Jaeger exporter should wait for each batch export.
"""

@deprecated(
version="1.16.0",
reason="Since v1.35, the Jaeger supports OTLP natively. Please use the OTLP exporter instead. Support for this exporter will end July 2023.",
)
def __init__(
self,
collector_endpoint: Optional[str] = None,
Expand Down
6 changes: 6 additions & 0 deletions ...opentelemetry-exporter-jaeger-thrift/src/opentelemetry/exporter/jaeger/thrift/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@
from os import environ
from typing import Optional

from deprecated import deprecated

from opentelemetry import trace
from opentelemetry.exporter.jaeger.thrift.gen.jaeger import (
Collector as jaeger_thrift,
Expand Down Expand Up @@ -130,6 +132,10 @@ class JaegerExporter(SpanExporter):
timeout: Maximum time the Jaeger exporter should wait for each batch export.
"""

@deprecated(
version="1.16.0",
reason="Since v1.35, the Jaeger supports OTLP natively. Please use the OTLP exporter instead. Support for this exporter will end July 2023.",
)
def __init__(
self,
agent_host_name: Optional[str] = None,
Expand Down