Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements file for example #3126

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Fix requirements file for example #3126

merged 2 commits into from
Jan 12, 2023

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 11, 2023

Fixes #3125

@lzchen lzchen requested a review from a team January 11, 2023 20:59
@lzchen lzchen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 11, 2023
@lzchen lzchen merged commit 3ff277e into main Jan 12, 2023
keithkroeger added a commit to fidelity-contributions/open-telemetry-opentelemetry-python that referenced this pull request Jan 13, 2023
* main:
  fixed all instances of @tracer.start_as_current_span("name"): to @tracer.start_as_current_span("name") as decorators do not have colons (open-telemetry#3127)
  Add attribute name to type warning message. (open-telemetry#3124)
  Fix requirements file for example (open-telemetry#3126)
  Add db metric name to semantic conventions (open-telemetry#3115)
  Adds environment variables for log exporter (open-telemetry#3037)
  Fix bug in example (open-telemetry#3111)
@lzchen lzchen deleted the lzchen-patch-1 branch February 13, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The preferred_temporality.py and preferred_aggregation.py sample code doesn't work
3 participants