Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http-metrics to semantic conventions #2976

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Add http-metrics to semantic conventions #2976

merged 2 commits into from
Oct 13, 2022

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Oct 12, 2022

No description provided.

@lzchen lzchen requested a review from a team October 12, 2022 19:27
@lzchen lzchen added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Oct 12, 2022
aabmass
aabmass approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code generated or you just manually added them?

@lzchen
Copy link
Contributor Author

lzchen commented Oct 12, 2022

@aabmass

Added manually. I know there's a gen script but it seems to be only for trace. I can create an issue to update it.

@ocelotl ocelotl merged commit 321f90f into open-telemetry:main Oct 13, 2022
@lzchen lzchen deleted the sem branch October 13, 2022 15:45
@lzchen lzchen mentioned this pull request Oct 13, 2022
Closed
@lmolkova lmolkova mentioned this pull request Sep 28, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@aabmass aabmass aabmass approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzchen @aabmass @ocelotl