Fix otlp exporter error handling misusing backoff.expo #2945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code doesn't work at all. If you try to run the example and end up with an error from the exporter, everything fall-apart due to the backoff code:
As it turns out,
backoff.expo
always yieldNone
first: https://github.com/litl/backoff/blob/master/backoff/_wait_gen.py#L23Type of change
How Has This Been Tested?
Ran on my machine. With this fix the code above now result with:
Does This PR Require a Contrib Repo Change?
Checklist: