Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning message for OTLP gRPC exporter mixin #2781

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Fix warning message for OTLP gRPC exporter mixin #2781

merged 7 commits into from
Jul 7, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jun 24, 2022

Fixes #2780

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 24, 2022
@ocelotl ocelotl requested a review from a team June 24, 2022 14:50
@ocelotl ocelotl self-assigned this Jun 24, 2022
@ocelotl ocelotl force-pushed the issue_2780 branch 3 times, most recently from a6c0d6c to b09fe25 Compare June 24, 2022 15:46
codeboten
codeboten reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding a changelog with the fix as it's user facing error messages.

@ocelotl ocelotl requested review from srikanthccv and codeboten June 27, 2022 08:10
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jun 27, 2022
@ocelotl ocelotl mentioned this pull request Jul 5, 2022
Open
@ocelotl ocelotl requested a review from srikanthccv July 6, 2022 16:10
@ocelotl ocelotl merged commit fe26ada into open-telemetry:main Jul 7, 2022
@ocelotl ocelotl deleted the issue_2780 branch July 7, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong warning in exporter mixin
4 participants
@ocelotl @codeboten @lzchen @srikanthccv