Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2348, add handling for non recording span in jaeger propagator #2762

Merged
merged 3 commits into from
Jun 15, 2022

Conversation

bluesliverx
Copy link
Contributor

@bluesliverx bluesliverx commented Jun 14, 2022

Fixes #2348

Description

This is a simple fix for #2348, where the jaeger exporter fails to handle a NonRecordingSpan correctly. It just basically skips the parent ID retrieval and moves along as if nothing else happened. This only occurs when a NonRecordingSpan has a valid context, which apparently we have trigged periodically in our app.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I created a new unit test inspired by an existing test, but done with a NonRecordingSpan to ensure that this doesn't cause the process to fail.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • [n/a] Changelogs have been updated
  • Unit tests have been added
  • [n/a] Documentation has been updated

@bluesliverx bluesliverx requested a review from a team June 14, 2022 02:58
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bluesliverx / name: Brian Saville (4541883)

@bluesliverx
Copy link
Contributor Author

I have requested to be added to the approved contributor list for Adobe for the CLA, will hopefully hear back in the next day or so on that.

@bluesliverx
Copy link
Contributor Author

Thanks for the review @ocelotl, I've updated the PR based on your comments.

@bluesliverx bluesliverx changed the title Fix #2348, add handling for non recording span in jaeger exporter Fix #2348, add handling for non recording span in jaeger propagator Jun 14, 2022
@bluesliverx
Copy link
Contributor Author

The CLA step should be done now. I'm not sure why it is still showing as missing. I've gone through EasyCLA at least twice and it said I'm good to go.

@bluesliverx
Copy link
Contributor Author

I realized EasyCLA was telling me that I had the wrong user (my work email) instead of my private email on the commit. I went and and just combined them all into a single commit and changed the author on them. Things should be good to go now. Not sure if it needs re-approvals since I rewrote history or not. @ocelotl @lzchen

@bluesliverx
Copy link
Contributor Author

Ran into pylint errors, I believe I have those all fixed now if you take another look. Sorry for the extra trouble.

@ocelotl ocelotl merged commit b03b5ca into open-telemetry:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NonRecordingSpan' object has no attribute 'parent'
3 participants