Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check data point before yielding #2745

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jun 7, 2022

Fixes #2743

@ocelotl ocelotl added the metrics label Jun 7, 2022
@ocelotl ocelotl requested a review from a team June 7, 2022 17:12
@ocelotl ocelotl self-assigned this Jun 7, 2022
@ocelotl ocelotl force-pushed the issue_2743 branch 2 times, most recently from 2d24994 to eb817f6 Compare June 8, 2022 16:15
@tkinz27
Copy link

tkinz27 commented Jun 8, 2022

This should fix #2725 as well right?

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. For cumulative readers though, we need to make sure they return the previous point value instead of None. For example, with a prometheus exporter:

counter.add(10, {"foo": "bar"})
# gets scraped, reports 10 for {foo="bar"}
# ... no measurements

# gets scraped again, should continue to report 10 for {foo="bar"}
# even though there were no measurements.

Do you know if that is the case? If not we should open another issue for rc2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'attributes'
5 participants