Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add more documentation to metrics API #2615

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Apr 18, 2022

While adding documentation i've also added some type annotations.

Related #2129

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 18, 2022
@codeboten codeboten requested a review from a team April 18, 2022 19:32
@lzchen
Copy link
Contributor

lzchen commented Apr 18, 2022

Does #2129 only refer to api docs?

Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzchen as far as i understand it was for API and SDK.

@ocelotl ocelotl merged commit bfeb4b8 into open-telemetry:main Apr 19, 2022
@codeboten codeboten deleted the codeboten/docs-metrics-init branch April 19, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants