Fix dependency for otlp exporter #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`opentelemetry-sdk ~= 1.10.0` prevents from upgrading to 1.11.0. Changing to greater than.
srikanthccv
approved these changes
Apr 14, 2022
|
Hmm, small question, if there are some additive changes in 1.11.0 sdk that are used by exporter then shouldn't we be changing this to >= 1.11.0 in the release PR itself? |
Yes I will be making that change in the release PR. |
ocelotl
approved these changes
Apr 15, 2022
|
What I had in my mind was actually would we have changed the min compatible version if it weren't notified by failure? We had a buggy release in the past with similar issue #2442. |
|
@srikanthccv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opentelemetry-sdk ~= 1.10.0prevents from upgrading to 1.11.0. Changing to greater than.