Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen up the dependency on backoff #2575

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Loosen up the dependency on backoff #2575

merged 4 commits into from
Mar 31, 2022

Conversation

teddylear
Copy link
Contributor

@teddylear teddylear commented Mar 29, 2022 •
edited
Loading

Description

Updating backoff lib dependency for otpl-proto-grpc exporter to be more lax with version constraints.

Fixes #2384

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 29, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: teddylear / name: teddylear (f092dd8)

@teddylear teddylear force-pushed the lax-backoff-dependency branch from f092dd8 to 566da97 Compare March 29, 2022 22:12
@teddylear teddylear changed the title [WIP] chore: edit otpl_proto-grpc dependencies to be more lax for backoff lib [WIP] chore: edit otpl-proto-grpc exporter dependencies to be more lax for backoff lib Mar 30, 2022
@teddylear teddylear marked this pull request as ready for review March 30, 2022 03:48
@teddylear teddylear requested a review from a team March 30, 2022 03:48
@teddylear teddylear changed the title [WIP] chore: edit otpl-proto-grpc exporter dependencies to be more lax for backoff lib chore: edit otlp-proto-grpc exporter dependencies to be more lax for backoff lib Mar 30, 2022
@srikanthccv
Copy link
Member

@teddylear Please do the same in proto-http exporter also.

@srikanthccv srikanthccv changed the title chore: edit otlp-proto-grpc exporter dependencies to be more lax for backoff lib Loosen up the dependency on backoff Mar 30, 2022
@teddylear
Copy link
Contributor Author

@srikanthccv will do 👍, I'll message when I've pushed an update.

@teddylear
Copy link
Contributor Author

@srikanthccv Updated with changes. Please let me know if there's anything else I should change. Thanks!

srikanthccv
srikanthccv approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teddylear

@lzchen lzchen merged commit b2e9387 into open-telemetry:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loosen up the dependency on backoff.
3 participants
@teddylear @srikanthccv @lzchen