Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix View doc string #2551

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Fix View doc string #2551

merged 1 commit into from
Mar 24, 2022

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Mar 24, 2022

Description

Sphinx expects constructors to be documented in the class's docstring, not the __init__ method's. Move the View.__init__ docstring to the class as Sphinx is expecting. Otherwise, the documentation doesn't get generated.

Type of change

Please delete options that are not relevant.

n/a

How Has This Been Tested?

n/a

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Documentation has been updated

@aabmass aabmass added doc Documentation-related metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Mar 24, 2022
@aabmass aabmass requested a review from a team March 24, 2022 21:29
@ocelotl ocelotl merged commit 0702852 into open-telemetry:main Mar 24, 2022
@aabmass aabmass deleted the fix-view-docs branch March 24, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants