Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InMemoryMetricReader to metrics SDK #2540

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Mar 18, 2022

Description

Fixes #2539

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit test

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass added sdk Affects the SDK package. metrics labels Mar 18, 2022
@aabmass aabmass requested a review from a team March 18, 2022 21:58
@aabmass aabmass force-pushed the 2539-in-mem-exporter branch from 1665eae to 24561c6 Compare March 18, 2022 22:07
@aabmass aabmass force-pushed the 2539-in-mem-exporter branch from 24561c6 to 2832f87 Compare March 18, 2022 22:13
@lzchen
Copy link
Contributor

lzchen commented Mar 22, 2022

@aabmass

The only thing missing there is a timeout which you would need a background thread/coroutine for regardless.

That's a good point. We can discuss on our recommendation of how to achieve the above scenario outside of this PR.

@ocelotl ocelotl merged commit 95aeecc into open-telemetry:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement InMemoryMetricExporter
3 participants