-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OTLP/HTTP log exporter #2462
Conversation
…hon into issue-2446
Sorry, I'm pretty new to this, where is this defined in the spec, @srikanthccv? |
|
...xporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/__init__.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_log_exporter.py
Show resolved
Hide resolved
Is this marked as draft due to this? |
I was actually thinking of getting #2583 before this. Also this is marked draft before that issue created. |
This is ready for review again. |
...otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/encoder/__init__.py
Show resolved
Hide resolved
...xporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/__init__.py
Show resolved
Hide resolved
@ocelotl :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stumbled upon your PR, hope you don't mind the comments.
...xporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_log_exporter/encoder/__init__.py
Show resolved
Hide resolved
Sorry, reviewing! 😅 |
Description
Fixes #2446
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e opentelemetry-exporter-otlp-proto-http
Does This PR Require a Contrib Repo Change?
Checklist: