Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTLP/HTTP log exporter #2462

Merged
merged 34 commits into from
Jun 13, 2022

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Feb 12, 2022

Description

Fixes #2446

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e opentelemetry-exporter-otlp-proto-http
  • Manually tested

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@srikanthccv srikanthccv marked this pull request as ready for review February 13, 2022 12:38
@srikanthccv srikanthccv requested a review from a team February 13, 2022 12:38
@lzchen lzchen mentioned this pull request Mar 1, 2022
4 tasks
@ocelotl
Copy link
Contributor

ocelotl commented Mar 22, 2022

Sorry, I'm pretty new to this, where is this defined in the spec, @srikanthccv?

@srikanthccv
Copy link
Member Author

@srikanthccv srikanthccv marked this pull request as draft April 2, 2022 11:31
@lzchen
Copy link
Contributor

lzchen commented Apr 4, 2022

Is this marked as draft due to this?

@srikanthccv
Copy link
Member Author

I was actually thinking of getting #2583 before this. Also this is marked draft before that issue created.

@srikanthccv srikanthccv marked this pull request as ready for review May 18, 2022 20:32
@srikanthccv
Copy link
Member Author

This is ready for review again.

@srikanthccv srikanthccv requested a review from ocelotl May 20, 2022 16:28
@srikanthccv
Copy link
Member Author

@ocelotl :)

3v58ic

Copy link

@HawaiianSpork HawaiianSpork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stumbled upon your PR, hope you don't mind the comments.

@ocelotl
Copy link
Contributor

ocelotl commented Jun 13, 2022

@ocelotl :)

3v58ic

Sorry, reviewing! 😅

@srikanthccv srikanthccv merged commit e073d4d into open-telemetry:main Jun 13, 2022
@srikanthccv srikanthccv deleted the issue-2446 branch June 13, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OTLP/HTTP logging exporter
4 participants