Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fix public checker #2459

Closed
wants to merge 2 commits into from
Closed

test fix public checker #2459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f7766e
Only check for public symbols in public packages
aabmass Feb 10, 2022
e9987e7
For demonstration only
aabmass Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions opentelemetry-api/tests/trace/test_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,5 @@ def test_description_and_non_error_status(self):
)
self.assertIs(status.status_code, StatusCode.ERROR)
self.assertEqual(status.description, "status description")

Foo = "should not fail"
2 changes: 2 additions & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,3 +242,5 @@ def get_meter(
self._measurement_consumer,
)
return self._meters[info]

Foo = "Should not fail"
2 changes: 2 additions & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,3 +1165,5 @@ def force_flush(self, timeout_millis: int = 30000) -> bool:
False if the timeout is exceeded, True otherwise.
"""
return self._active_span_processor.force_flush(timeout_millis)

Foo = "should fail"
1 change: 1 addition & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/testsfoo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Foo = "should fail"
10 changes: 9 additions & 1 deletion scripts/public_symbols_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,18 @@ def get_symbols(change_type, diff_lines_getter, prefix):
):

b_file_path = diff_lines.b_blob.path
b_file_path_obj = Path(b_file_path)

if (
Path(b_file_path).suffix != ".py"
b_file_path_obj.suffix != ".py"
or "opentelemetry" not in b_file_path
or any(
# single leading underscore
part[0] == "_" and part[1] != "_"
# tests directories
or part == "tests"
for part in b_file_path_obj.parts
)
):
continue

Expand Down