Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Rework API docs #2453

Merged
merged 12 commits into from
Feb 28, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 9, 2022

/cc @cartermp @austinlparker

Preview: ... hmm, I'm not sure how to link to a preview -- anyone else know? In the meantime, I've included a screenshot below.


image

@chalin
Copy link
Contributor Author

chalin commented Feb 9, 2022

It might be desirable to implement Redirects for pages that have been renamed or removed, but apparently it requires access to the readthedocs.org account, which I don't have access to. Let me know if you think this is worth exploring further, and who might be available to help set it up.

docs/index.rst Outdated Show resolved Hide resolved
@chalin chalin requested a review from ocelotl February 10, 2022 13:46
@lzchen
Copy link
Contributor

lzchen commented Feb 10, 2022

Is there a place we can put the excerpt related to benchmarks?

Click here https://open-telemetry.github.io/opentelemetry-python/benchmarks/index.html_ to view the latest performance benchmarks for packages in this repo.

@chalin
Copy link
Contributor Author

chalin commented Feb 10, 2022

Is there a place we can put the excerpt related to benchmarks?

@izchen, the intent of

is to avoid non-API info in the API reference pages. The link to benchmarks is available from the Python landing page (or will be once open-telemetry/opentelemetry.io#1116 is merged).

@lzchen
Copy link
Contributor

lzchen commented Feb 10, 2022

@chalin
Should a benchmarks.md exist here then?

@chalin
Copy link
Contributor Author

chalin commented Feb 11, 2022

@chalin Should a benchmarks.md exist here then?

I does (in a sense I explain next), I just merged the PR (open-telemetry/opentelemetry.io#1116) that adds the link to the benchmarks to that page.

Note that I didn't add the content of benchmarks.md because that page just told user to "click 'here'". Instead I added the direct link:

image

@chalin chalin force-pushed the chalin-link-to-otel-io-2022-02-09 branch from fcced5c to 1f86f07 Compare February 14, 2022 23:31
@chalin
Copy link
Contributor Author

chalin commented Feb 15, 2022

Thanks for the thumbs up on my last comment @lzchen.

All: are there any points left to address before this gets approved and merged? Thanks.

@chalin
Copy link
Contributor Author

chalin commented Feb 16, 2022

I noticed that other doc changes had a CHANGELOG entry, so I added one. PTAL.

@chalin
Copy link
Contributor Author

chalin commented Feb 16, 2022

I've also updated the opening comment to explicitly list the pages that have moved along with what they redirect to.

@chalin
Copy link
Contributor Author

chalin commented Feb 22, 2022

Followup to last week's ping: is there anything left to do before this can get merged?

@lzchen
Copy link
Contributor

lzchen commented Feb 22, 2022

@ocelotl
Have your comments been addressed?

@chalin
Copy link
Contributor Author

chalin commented Feb 24, 2022

Thanks all for your approvals. Can this be merged now?

@lzchen lzchen merged commit 6f8e9d3 into open-telemetry:main Feb 28, 2022
@chalin chalin deleted the chalin-link-to-otel-io-2022-02-09 branch March 2, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants