-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Rework API docs #2453
[docs] Rework API docs #2453
Conversation
4f88b86
to
6e6e2c6
Compare
It might be desirable to implement Redirects for pages that have been renamed or removed, but apparently it requires access to the readthedocs.org account, which I don't have access to. Let me know if you think this is worth exploring further, and who might be available to help set it up. |
Is there a place we can put the excerpt related to benchmarks?
|
@izchen, the intent of is to avoid non-API info in the API reference pages. The link to benchmarks is available from the Python landing page (or will be once open-telemetry/opentelemetry.io#1116 is merged). |
I does (in a sense I explain next), I just merged the PR (open-telemetry/opentelemetry.io#1116) that adds the link to the benchmarks to that page. Note that I didn't add the content of |
Co-authored-by: Diego Hurtado <[email protected]>
fcced5c
to
1f86f07
Compare
Thanks for the thumbs up on my last comment @lzchen. All: are there any points left to address before this gets approved and merged? Thanks. |
…m/chalin/opentelemetry-python into chalin-link-to-otel-io-2022-02-09
I noticed that other doc changes had a CHANGELOG entry, so I added one. PTAL. |
I've also updated the opening comment to explicitly list the pages that have moved along with what they redirect to. |
Followup to last week's ping: is there anything left to do before this can get merged? |
@ocelotl |
Thanks all for your approvals. Can this be merged now? |
/cc @cartermp @austinlparker
Preview: ... hmm, I'm not sure how to link to a preview -- anyone else know? In the meantime, I've included a screenshot below.