Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return noopmeter on invalid name getmeter #2428

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Return noopmeter on invalid name getmeter #2428

merged 3 commits into from
Feb 1, 2022

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 31, 2022

Fixes #1200

@lzchen lzchen requested a review from a team January 31, 2022 20:48
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 31, 2022
@lzchen lzchen closed this Feb 1, 2022
@lzchen lzchen reopened this Feb 1, 2022
@lzchen lzchen merged commit d71cf68 into open-telemetry:main Feb 1, 2022
@lzchen lzchen deleted the name branch February 1, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An invalid name should return a working no-op Meter implementation
3 participants
@lzchen @codeboten @ocelotl