Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly decrease wait time #2417

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Slightly decrease wait time #2417

merged 1 commit into from
Jan 26, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jan 26, 2022

Fixes #2416

@ocelotl ocelotl requested a review from srikanthccv January 26, 2022 22:48
@ocelotl ocelotl self-assigned this Jan 26, 2022
@ocelotl ocelotl requested a review from a team January 26, 2022 22:48
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 26, 2022
@ocelotl ocelotl changed the title Slightly increase wait time Slightly decrease wait time Jan 26, 2022
srikanthccv
srikanthccv approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

codeboten
codeboten approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change just masking an underlying problem? I'm asking because if so, we should leave the issue open until we can investigate its cause. I'm ok with approving this change to unblock CI though.

@ocelotl ocelotl merged commit e780a97 into open-telemetry:main Jan 26, 2022
@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 26, 2022

Is this change just masking an underlying problem? I'm asking because if so, we should leave the issue open until we can investigate its cause. I'm ok with approving this change to unblock CI though.

Thanks, opened #2418 to track this.

@ocelotl ocelotl deleted the issue_2416 branch January 26, 2022 23:15
@ocelotl ocelotl mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestPeriodicExportingMetricReader.test_ticker_collects_metrics fails randomly
3 participants
@ocelotl @codeboten @srikanthccv