Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding implementation for Gauge #2408

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Adding implementation for Gauge #2408

merged 3 commits into from
Jan 25, 2022

Conversation

codeboten
Copy link
Contributor

Fixes #2385

@codeboten codeboten requested a review from a team January 25, 2022 00:16
ocelotl
ocelotl approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just minor changes requested ✌️

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py Outdated Show resolved Hide resolved
exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py Show resolved Hide resolved
@ocelotl
Update exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/…
7bffffe 
…test_otlp_metrics_exporter.py

Co-authored-by: Diego Hurtado <[email protected]>
@ocelotl ocelotl merged commit f0583e3 into open-telemetry:main Jan 25, 2022
@codeboten codeboten deleted the codeboten/add-sum branch January 25, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTLP Exporter: Add support for Gauge point types
3 participants
@codeboten @ocelotl @srikanthccv