-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Asynchronous and Synchronous sum aggregations #2379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know in my original prototype and doc, we had collect() -> Optional[Point]
so that "the aggregations may also return None if no measurements were seen in this interval–the metric reader won't see see the point in this case." I remember there being some specification discussion around whether or not this is correct, but can't dig anything up.
Given the confusion and fact that this would be an optimization, should put that off till later and just do the simple thing to start?
All right, removed any association between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address conflicts.
Done, @aabmass plese review ✌️ |
Co-authored-by: Aaron Abbott <[email protected]>
This is done in order to identify the situation when aggregate has not been called before collect is.
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Abbott <[email protected]>
Fixes #2353