Add logging signal to main #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use timeout in force_flush * fix lint * Update opentelemetry-sdk/src/opentelemetry/sdk/logs/export/__init__.py Co-authored-by: Srikanth Chekuri <[email protected]> * fix lint Co-authored-by: Srikanth Chekuri <[email protected]>
Co-authored-by: Srikanth Chekuri <[email protected]>
* Fix exception with warning message transformation * Fix lint * Fix lint
* Demonstrate how to set the Resource for LogEmitterProvider
Added a Resource to the logs example to make it more complete.
Previously it was using the built-in Resource. Now it adds the
service.name and service.instance.id attributes.
The resulting emitted log records look like this:
```
Resource labels:
-> telemetry.sdk.language: STRING(python)
-> telemetry.sdk.name: STRING(opentelemetry)
-> telemetry.sdk.version: STRING(1.5.0)
-> service.name: STRING(shoppingcart)
-> service.instance.id: STRING(instance-12)
InstrumentationLibraryLogs #0
InstrumentationLibrary __main__ 0.1
LogRecord #0
Timestamp: 2021-10-14 18:33:43.425820928 +0000 UTC
Severity: ERROR
ShortName:
Body: Hyderabad, we have a major problem.
Trace ID: ce1577e4a703f42d569e72593ad71888
Span ID: f8908ac4258ceff6
Flags: 1
```
* Fix linting
* move logs to _logs * fix lint
lzchen
added
the
Approve Public API check
lzchen
reviewed
Oct 29, 2021
lzchen
approved these changes
Oct 29, 2021
lzchen
reviewed
Oct 29, 2021
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py
Outdated
Show resolved
Hide resolved
owais
approved these changes
Oct 29, 2021
|
It appears I cannot update the branch. Looks like branch protection is preventing me from doing so. @open-telemetry/python-maintainers |
|
I couldn't either with the following error.
|
|
@owais yeah i think you'll have to disable branch protection to be able to update the branch :( |
|
I'm not sure which setting I need to change to remove this so I temporarily disabled it, updated and enabled again. |
|
It looks like it should be this:
but I'm part of that group and should have been able to update if that was it. |
|
BTW is this branch good to be merged? Should I enable auto-merge? |
|
@owais its good to go as far as i know. |
|
@owais @codeboten it looks like this got squashed into 7c90cf4 instead of rebase and merged? |
|
doh :( |
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Nov 3, 2021
This reverts commit 7c90cf4.
|
Revert change here: #2260 |
lzchen
pushed a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following PR adds experimental signal support for logging. Note to maintainers: please remember to not squash this change.
Part of #1890
Not marking that issue as fixed until this signal is no longer experimental.
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: