Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt resource attributes from span limits #2138

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Sep 22, 2021

Description

Exempts resources from attribute limits as is now recommended by the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md#exempt-entities

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Updated existing test

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the exempt-resource-from-limits branch from 6fee7da to 82f841c Compare September 22, 2021 23:56
@owais owais marked this pull request as ready for review September 22, 2021 23:57
@owais owais requested a review from a team September 22, 2021 23:57
@owais owais enabled auto-merge (squash) September 25, 2021 00:36
@owais owais merged commit b2d5ab3 into open-telemetry:main Sep 25, 2021
@owais owais deleted the exempt-resource-from-limits branch September 25, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants