Add test base class with local HTTP server. #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
srikanthccv
approved these changes
Sep 14, 2021
codeboten
approved these changes
Sep 15, 2021
lzchen
approved these changes
Sep 16, 2021
lzchen
added
the
Approve Public API check
|
Thank you for reviewing & approving this PR. The dependent open-telemetry/opentelemetry-python-contrib#661 would also need some 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new test base class that starts a localhost HTTP server. It is used for tests in this contrib PR: open-telemetry/opentelemetry-python-contrib#661
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This is a test utility. It has not been tested by itself.
Does This PR Require a Contrib Repo Change?
No, but this change is required for a contrib PR: open-telemetry/opentelemetry-python-contrib#661
Checklist:
[ ] Unit tests have been added[ ] Documentation has been updated