Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contextvars workaround #2009

Merged
merged 6 commits into from
Aug 16, 2021
Merged

Remove contextvars workaround #2009

merged 6 commits into from
Aug 16, 2021

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 29, 2021

Fixes #2008

@ocelotl ocelotl self-assigned this Jul 29, 2021
@ocelotl ocelotl requested review from a team, owais and lzchen and removed request for a team July 29, 2021 21:55
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 29, 2021
codeboten
codeboten reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment, I believe we still need the aiocontextvars import, but I'd be happy to clean up the unused older code.

@ocelotl ocelotl requested a review from codeboten July 29, 2021 22:20
codeboten
codeboten approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the conflicts.

@lzchen lzchen merged commit 4e0642b into open-telemetry:main Aug 16, 2021
@ocelotl ocelotl deleted the issue_2008 branch August 17, 2021 07:59
owais pushed a commit to owais/opentelemetry-python that referenced this pull request Aug 17, 2021
@ocelotl @owais
Remove contextvars workaround (open-telemetry#2009)
06cb444
owais pushed a commit to owais/opentelemetry-python that referenced this pull request Aug 17, 2021
@ocelotl @owais
Remove contextvars workaround (open-telemetry#2009)
796589d
owais pushed a commit to owais/opentelemetry-python that referenced this pull request Aug 17, 2021
@ocelotl @owais
Remove contextvars workaround (open-telemetry#2009)
f17f7b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

@owais owais Awaiting requested review from owais

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove contextvars workaround
5 participants
@ocelotl @codeboten @aabmass @lzchen @owais