Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Back to develop after 1.4.0 release #1985

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Back to develop after 1.4.0 release #1985

merged 6 commits into from
Jul 27, 2021

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jul 26, 2021 •
edited
Loading

No description provided.

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 26, 2021
@srikanthccv srikanthccv marked this pull request as ready for review July 26, 2021 19:03
@srikanthccv srikanthccv requested review from a team, owais and codeboten and removed request for a team July 26, 2021 19:03
@srikanthccv srikanthccv mentioned this pull request Jul 26, 2021
Merged
codeboten
codeboten approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! Please resolve the conflicts and we can merge 🚀

@owais
Copy link
Contributor

owais commented Jul 26, 2021

Should we be bumping dependencies to dev versions? I thought we had decided to pin all stable dependencies to >=1.3, <2.0 unless some package actually needs a new feature from a newer version. Have we not made all the changes to migrate to that pattern yet? If we have, I think we should start doing it now and not bump stable deps to dev versions. It'll ensure that:

  • Any packages that need newer features from other stable packages will fail fast in dev and allow us to catch such issues.
  • Allow people to install a specific package from directly from git while using all other packages from pypi.org

@srikanthccv
Copy link
Member Author

I don't know what was the reasoning but right now it is a mix of bumping and pinning ~= 1.3 version. I can make that change for all if there is no issue.

@ocelotl
Copy link
Contributor

ocelotl commented Jul 27, 2021 •
edited
Loading

Should we be bumping dependencies to dev versions?

@owais, sounds reasonable, but I say we do this in a separate PR. ✌️

@ocelotl ocelotl merged commit 3992778 into open-telemetry:main Jul 27, 2021
@srikanthccv srikanthccv deleted the 1.5-chore branch September 24, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

@owais owais owais approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srikanthccv @owais @ocelotl @codeboten @lzchen