Generate semconv constants update for OTel Spec 1.5.0 #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
a team,
ocelotl and
lzchen
and removed request for
a team
aabmass
approved these changes
Jul 12, 2021
aabmass
reviewed
Jul 12, 2021
| DEVICE_ID = "device.id" | ||
| """ | ||
| A unique identifier representing the device. | ||
| Note: The device identifier MUST only be defined using the values outlined below. This value is not an advertising identifier and MUST NOT be used as such. On iOS (Swift or Objective-C), this value MUST be equal to the [vendor identifier](https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor). On Android (Java or Kotlin), this value MUST be equal to the Firebase Installation ID or a globally unique UUID which is persisted across sessions in your application. More information can be found [here](https://developer.android.com/training/articles/user-data-ids) on best practices and exact implementation details. Caution should be taken when storing personal data or anything which can identify a user. GDPR and data protection laws may apply, ensure you do your own due diligence. |
There was a problem hiding this comment.
Can we update the template to reflow long text? https://jinja.palletsprojects.com/en/2.11.x/templates/#wordwrap
There was a problem hiding this comment.
Looks like if I update generate.sh like this:
- {{attribute.brief | to_doc_brief}}.
+ {{attribute.brief | to_doc_brief | wordwrap}}.
it doesn't do the tabs properly 😕
DEVICE_ID = "device.id"
"""
A unique identifier representing the device.
Note: The device identifier MUST only be defined using the values outlined below.
This value is not an advertising identifier and MUST NOT be used as such. On
iOS (Swift or Objective-C), this value MUST be equal to the [vendor identifier]
(https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierfor
vendor). On Android (Java or Kotlin), this value MUST be equal to the Firebase
Installation ID or a globally unique UUID which is persisted across sessions in
your application. More information can be found
[here](https://developer.android.com/training/articles/user-data-ids) on best
practices and exact implementation details. Caution should be taken when
storing personal data or anything which can identify a user. GDPR and data
protection laws may apply, ensure you do your own due diligence.
"""
srikanthccv
approved these changes
Jul 13, 2021
srikanthccv
added
the
Approve Public API check
codeboten
approved these changes
Jul 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the semantic conventions constants to the v1.5.0 tag using the
./scripts/semconv/generate.shscript.Additionally, after learning how to run the script by updating the Docker image tag with @lonewolf3739 's help from this Slack message, I thought it would be helpful to pull that tag version out as a variable in the
generate.shscript.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I manually checked all the variables which changed and ensured that no one in contrib or core was using them. Other than that no tests are needed.
Does This PR Require a Contrib Repo Change?
Checklist:
- [ ] Unit tests have been added- [ ] Documentation has been updated(Not needed?)