Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default TraceContext propagator in example #188

Merged
merged 8 commits into from
Jan 31, 2020

Conversation

c24t
Copy link
Member

@c24t c24t commented Sep 30, 2019

This PR updates the flask example to use the W3C propagator following #180.

@c24t c24t added the doc Documentation-related label Sep 30, 2019
@c24t c24t requested a review from toumorokoshi September 30, 2019 20:42
@toumorokoshi
Copy link
Member

There's unit tests that verify b3 propagation. Those should be changed to use TraceContext.

@a-feld a-feld removed their request for review December 10, 2019 00:57
@c24t c24t requested a review from a team January 30, 2020 20:02
@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #188 into master will decrease coverage by <.01%.
The diff coverage is 85.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   85.32%   85.32%   -0.01%     
==========================================
  Files          38       38              
  Lines        1929     1928       -1     
  Branches      227      227              
==========================================
- Hits         1646     1645       -1     
  Misses        218      218              
  Partials       65       65
Impacted Files Coverage Δ
opentelemetry-api/src/opentelemetry/util/loader.py 81.25% <ø> (ø) ⬆️
...pentelemetry/context/propagation/httptextformat.py 100% <100%> (ø) ⬆️
...try-ext-wsgi/src/opentelemetry/ext/wsgi/version.py 100% <100%> (ø) ⬆️
...elemetry-api/src/opentelemetry/metrics/__init__.py 88.13% <100%> (+0.2%) ⬆️
opentelemetry-sdk/src/opentelemetry/sdk/util.py 85.88% <100%> (ø) ⬆️
...sts/src/opentelemetry/ext/http_requests/version.py 100% <100%> (ø) ⬆️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.74% <100%> (ø) ⬆️
...elemetry-api/src/opentelemetry/context/__init__.py 100% <100%> (ø) ⬆️
...him/src/opentelemetry/ext/opentracing_shim/util.py 100% <100%> (ø) ⬆️
...pentelemetry-sdk/src/opentelemetry/sdk/__init__.py 100% <100%> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72991b7...e4ce950. Read the comment docs.

@c24t c24t merged commit aecc347 into open-telemetry:master Jan 31, 2020
@c24t c24t deleted the update-example-for-180 branch January 31, 2020 23:58
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Feb 17, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants