Introduce SpanLimits class to tracing SDK #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
tracer-provider-limits
branch
3 times, most recently
from
eea6ec6 to
8bcdd5a
Compare
owais
force-pushed
the
tracer-provider-limits
branch
from
8bcdd5a to
8194e99
Compare
owais
requested review from
a team,
srikanthccv,
codeboten and
ocelotl
and removed request for
a team
srikanthccv
reviewed
May 27, 2021
srikanthccv
reviewed
May 27, 2021
srikanthccv
reviewed
May 28, 2021
owais
force-pushed
the
tracer-provider-limits
branch
3 times, most recently
from
34006ab to
7dd97e6
Compare
owais
force-pushed
the
tracer-provider-limits
branch
from
7dd97e6 to
a800bc9
Compare
srikanthccv
approved these changes
May 30, 2021
lzchen
approved these changes
Jun 1, 2021
lzchen
added
the
Approve Public API check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This renames the internal
_Limitsclass toSpanLimitsand allows an instance of SpanLimits to be passed to TracerProvider.Implements the following proposal: discussion
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: