Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OTLP Exporter Protobuf over HTTP #1868
Add support for OTLP Exporter Protobuf over HTTP #1868
Changes from 5 commits
fe42a03
2428318
8007517
82bd4ad
391af28
d171369
176d60a
c252c38
92e005f
834d7b6
3766f84
f66811a
8c283f9
aaccd7f
2a8833e
0aa18ef
4b449e1
fd6206c
79c69ca
f091c73
5d8cba1
b5692ff
268fe36
88f84b9
17215e8
2bb3064
3562bbc
7b350e7
1d70df8
17ab52e
d009590
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might have to have a discussion on whether or not we can mark this as stable since collector is technically not stable (even though otlp grpc is stable). Will talk about it in the SIG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't get a chance to talk about this in the SIG but I agree w/ @lzchen, we should mark hold off marking this as stable until the port is confirmed. We can then merge this as beta until then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we decided not to use pinned versions after this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I haven't followed that development closely. This should be
opentelemetry-api ~= 1.3
, right?