-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename CompositeHTTPPropagator, add deprecation notice #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
a team,
owais and
ocelotl
and removed request for
a team
May 3, 2021 20:03
owais
approved these changes
May 3, 2021
lzchen
approved these changes
May 3, 2021
ocelotl
suggested changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the documentation as it is for deprecated objects, besides that, LGTM 👍
Co-authored-by: Diego Hurtado <[email protected]>
@ocelotl PTAL |
ocelotl
approved these changes
May 7, 2021
Approved 👍 |
ocelotl
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renaming CompositeHTTPPropagator to CompositePropagator. Note this change adds the dependency on the
Deprecated
package to the API, we may or may not want this, would love some feedback from reviewers. The following is what users will see when usingCompositeHTTPPropagator
:Fixes #1775
Type of change
Please delete options that are not relevant.
Does This PR Require a Contrib Repo Change?
Checklist: