OTLP exporter uses scheme from endpoint configuration

[codeboten]

Description

As per the specification, the otlp exporter must use the scheme from the endpoint to determine if a connection should be secure or not. https://github.com/open-telemetry/opentelemetry-specification/blob/f62744a679814937214fd17394ab3fa8a9099424/specification/protocol/exporter.md#configuration-options

A scheme of https indicates a secure connection.

Fixes #1747

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Ran manual tests w/ the collector locally

Does This PR Require a Contrib Repo Change?

• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated

[owais]

LGTM. Wondering if using urlparse would be better?

[ocelotl]

LGTM. Wondering if using urlparse would be better?

Yes, please, urlparse is part of the standard library:

>>> from urllib.parse import urlparse
>>> parse_result = urlparse("http://localhost:4317")
>>> parse_result.scheme
'http'
>>> parse_result.hostname
'localhost'
>>> parse_result.port
4317
>>> parse_result.netloc
'localhost:4317'

[ocelotl]

Approving since this fixes the issue, but please consider using urlparse, @codeboten ✌️

[codeboten]

Updated the code to use urlparse @owais @ocelotl

[srikanthccv]

did you intend to write is not here? Because there is a default value and I don't see how it can be None? Could you also add a test to insecure_channel?

[codeboten]

thank you for catching this, i meant to check for insecure, there's already a few tests for the insecure_channel but i can add one specifically with the endpoint parameter.

[codeboten]

test added if you can take a look @lonewolf3739

[srikanthccv]

LGTM