Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eachdist.py not printing invoked commands. #1758

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Apr 9, 2021

Description

I observed the following pattern:

<output of cmd 1>
<output of cmd 2>
>>> cmd1
>>> cmd2

The >>> cmd header should come immediately before the command output to facilitate debugging & progress reporting.

Also remove a leftover comment fragment.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Only locally.

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated: No, IMHO too minor but can do if requested
  • Unit tests have been added: N/A
  • Documentation has been updated: N/A

I observed the following pattern:
```
<output of cmd 1>
<output of cmd 2>
>>> cmd1
>>> cmd2
```

The `>>> cmd` header should come immediately before the command output to facilitate debugging & progress reporting.
@Oberon00 Oberon00 requested review from a team, codeboten and hectorhdzg and removed request for a team April 9, 2021 11:45
@Oberon00
Copy link
Member Author

Oberon00 commented Apr 9, 2021


No CHANGELOG was modified.
Please add a CHANGELOG entry, or add the "Skip Changelog" label if not required.

I cannot add that label, please tell me if I should add a changelog entry instead.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 9, 2021
@codeboten
Copy link
Contributor

I cannot add that label, please tell me if I should add a changelog entry instead.

Added the label, thanks!

@codeboten codeboten merged commit 6f8c077 into open-telemetry:main Apr 9, 2021
@Oberon00 Oberon00 deleted the patch-1 branch April 12, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants