Fixed B3 Propagator #1750
Merged
Fixed B3 Propagator #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
owais
force-pushed
the
fix-b3-propagator
branch
6 times, most recently
from
ed76e66 to
fba4e61
Compare
srikanthccv
reviewed
Apr 6, 2021
| @@ -97,6 +97,8 @@ def extract( | |||
| or self._trace_id_regex.fullmatch(trace_id) is None | |||
| or self._span_id_regex.fullmatch(span_id) is None | |||
| ): | |||
| if context is None: | |||
| return trace.set_span_in_context(trace.INVALID_SPAN, context) | |||
| return context | |||
There was a problem hiding this comment.
This should also fix the composite propagator issue. While you are at it, could you also fix another issue with B3 when there is a valid propagation header. context should be passed in this set_span_in_context call.
There was a problem hiding this comment.
Done. Also added tests to ensure the returned context is always derived from the provided one.
lzchen
approved these changes
Apr 6, 2021
srikanthccv
approved these changes
Apr 6, 2021
B3 propagator was returning `None` instead of invalid context after last change. This resulted in many apps crashing when B3 failed to extract a valid context from carrier. This PR patches it to not make apps crash and return an invalid context when one cannot be extracted from the carrier.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
B3 propagator was returning
Noneinstead of invalid context after lastchange. This resulted in many apps crashing when B3 failed to extract a
valid context from carrier. This PR patches it to not make apps crash
and return an invalid context when one cannot be extracted from the
carrier.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: