Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IdsGenerator to IdGenerator #1651

Merged
merged 8 commits into from
Feb 26, 2021
Merged

Rename IdsGenerator to IdGenerator #1651

merged 8 commits into from
Feb 26, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 26, 2021

Fixes #1629

@lzchen lzchen requested review from a team, codeboten and toumorokoshi and removed request for a team February 26, 2021 18:40
@lzchen lzchen mentioned this pull request Feb 26, 2021
Merged
codeboten
codeboten approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits, otherwise LGTM

@lzchen lzchen merged commit 290478e into open-telemetry:main Feb 26, 2021
@lzchen lzchen deleted the id branch February 26, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@owais owais owais approved these changes

@toumorokoshi toumorokoshi Awaiting requested review from toumorokoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename IdsGenerator to IdGenerator
3 participants
@lzchen @owais @codeboten