-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to work with fork process web server models(Gunicorn, uWSGI etc...) #1609
Conversation
Co-authored-by: Diego Hurtado <[email protected]>
…python into fork-process
@owais Updated the examples and documentation. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
Hello! Should there be disclaimer stating that if environment variable like Reason: Examples where filtering won't work: gunicorn.conf.py
app.py
Examples where filtering will work: app.py
|
@ash-ishh it isn't really related to this PR and to be precise the excluded urls list for third party packages is created when the instrumentations are imported eg: flask see here. It doesn't work if you import the instrumentation first and then set the env. This is the current behaviour for all the instrumentations irrespective the process models. |
Understood.. the reason I stumbled upon issue was because in Django while setting If in future enough people repeat the same mistake then maybe we might need to add disclaimer in Sorry for raising the issue in wrong place and thanks for the clarification :) |
@ocelotl |
Reviewed 👍 |
Description
Add how to work with fork process web server models(Gunicorn, uWSGI etc...)
Fixes open-telemetry/opentelemetry-python-contrib#291
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e docs
tox -e lint
Does This PR Require a Contrib Repo Change?
Checklist: