Upgrade isort and enable black compat mode #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
toumorokoshi and
lzchen
and removed request for
a team
owais
force-pushed
the
isort-and-black-be-friends
branch
6 times, most recently
from
835662c to
68ead87
Compare
isort and black can be incompatible. Often isort re-writes files in a way black doesn't like. It takes quite some time and manual effort to make changes that satisfy both isort and black. Fortunately, newer versions of isort support a black compatibility mode by setting isort profile to "black". This makes isort order imports in a way that is compatible with how black formats Python code. This PR configures isort to use the black profile by default.
owais
force-pushed
the
isort-and-black-be-friends
branch
from
68ead87 to
a0d478c
Compare
lzchen
approved these changes
Dec 11, 2020
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort and black can be incompatible. Often isort re-writes files in a
way black doesn't like. It takes quite some time and manual effort to
make changes that satisfy both isort and black.
Fortunately, newer versions of isort support a black compatibility mode by setting
isort profile to "black". This makes isort order imports in a way that
is compatible with how black formats Python code. This PR configures
isort to use the black profile by default.