Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.9 to build #1441

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Add Python 3.9 to build #1441

merged 1 commit into from
Dec 11, 2020

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Dec 2, 2020

Description

Add Python 3.9 to build

@gliptak gliptak requested review from a team, toumorokoshi and lzchen and removed request for a team December 2, 2020 19:34
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 2, 2020 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

codeboten
codeboten reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, any idea why the checks didn't get run by github actions?

@gliptak
Copy link
Contributor Author

gliptak commented Dec 3, 2020

@codeboten which checks you are referring to?

@codeboten
Copy link
Contributor

I would expect the checks here to show py39 as well
Screen Shot 2020-12-03 at 1 39 31 PM

@gliptak
Copy link
Contributor Author

gliptak commented Dec 3, 2020

Failed single test looks unrelaed

toumorokoshi
toumorokoshi suggested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

It looks like python3.8 is used as the primary version for linting and tracecontext in tox.ini. I think those should be bumped too.

@gliptak
Copy link
Contributor Author

gliptak commented Dec 4, 2020 •
edited
Loading

@toumorokoshi as per pylint-dev/pylint#3882 pylint support for 3.9 isn't complete.

toumorokoshi
toumorokoshi approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for looking into the linting.

codeboten
codeboten approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codeboten
Copy link
Contributor

@gliptak can you add an entry to the changelog for this?

@gliptak
Add Python 3.9 to build
51bee37 
Signed-off-by: Gábor Lipták <[email protected]>
@codeboten codeboten merged commit 3bbc547 into open-telemetry:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@codeboten codeboten codeboten approved these changes

@lzchen lzchen Awaiting requested review from lzchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gliptak @codeboten @toumorokoshi @ocelotl