Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1390 - Remove unexpected keyword argument in metrics_example #1433

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

s27y
Copy link
Contributor

@s27y s27y commented Nov 28, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1390 which is a minor bug introduced in #1254

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • New test file added test_metrics.py
  • A local test has been done, metrics_example.py code runs as expected:
    /home/yang/python-workspace/opentelemetry-python-example/metrics.py ConsoleMetricsExporter(data="Counter(name="requests", description="number of requests")", labels="(('environment', 'staging'),)", value=25, resource={'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '0.16b1'}) ConsoleMetricsExporter(data="Counter(name="requests", description="number of requests")", labels="(('environment', 'staging'),)", value=45, resource={'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '0.16b1'})

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@s27y s27y requested review from a team, codeboten and ocelotl and removed request for a team November 28, 2020 19:51
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2020

CLA Signed

The committers are authorized under a signed CLA.

@s27y s27y changed the title <WIP>Remove unexpected keyword argument Remove unexpected keyword argument in metrics_example Nov 28, 2020
@s27y s27y changed the title Remove unexpected keyword argument in metrics_example Fixes #1390 - Remove unexpected keyword argument in metrics_example Nov 28, 2020
Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @s27y!

@s27y
Copy link
Contributor Author

s27y commented Nov 30, 2020

@lzchen Thanks for the feedback. I've updated the func name.

@codeboten codeboten merged commit d202895 into open-telemetry:master Nov 30, 2020
@s27y s27y deleted the issue_1390 branch November 30, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants