Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meter to observers #1425

Merged
merged 8 commits into from
Nov 26, 2020
Merged

Add meter to observers #1425

merged 8 commits into from
Nov 26, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 26, 2020

Fixes #1424

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this work, just some initial feedback. Will review once again when it's out of draft mode.

opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
opentelemetry-sdk/tests/metrics/test_metrics.py Outdated Show resolved Hide resolved
@ocelotl ocelotl marked this pull request as ready for review November 26, 2020 22:17
@ocelotl ocelotl requested review from a team, toumorokoshi and aabmass and removed request for a team November 26, 2020 22:17
@ocelotl ocelotl requested a review from codeboten November 26, 2020 22:28
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeboten codeboten merged commit 8cc9260 into open-telemetry:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using OTLP to export a SumObserver
3 participants