Add missing references to instrumented packages #1416
Conversation
NathanielRN
requested review from
a team,
toumorokoshi and
lzchen
and removed request for
a team
NathanielRN
force-pushed
the
update-bootstrap-packages
branch
from
b594647 to
19cf4a7
Compare
|
Looking through it, I agree the code isn't documented enough to tell you what it's for. Conceptually, I believe this is part of a tool that looks at installed packages, and handles installing the appropriate instrumentations for you. This helps for those who prefer to turn on as much instrumentation as possible, and don't want to go through the manual process of combing through the libraries they use to figure out the instrumentations. Would you mind adding a comment to document the purpose of that list? it'll help the next contributor answer that question. |
| @@ -25,6 +25,8 @@ | |||
|
|
|||
| # target library to desired instrumentor path/versioned package name | |||
| instrumentations = { | |||
| "aiohttp-client": "opentelemetry-instrumentation-aiohttp-client>=0.15b0", | |||
There was a problem hiding this comment.
could you add the comment I asked above this, maybe right below the imports?
There was a problem hiding this comment.
Sweet that is super helpful! Added a comment :)
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py
Outdated
Show resolved
Hide resolved
opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap.py
Outdated
Show resolved
Hide resolved
NathanielRN
force-pushed
the
update-bootstrap-packages
branch
from
fd37bae to
f912baf
Compare
Description
I'm not sure what this list is for, but it seemed like an incomplete list of the packages for which we have instrumentation for. Added the missing packages (
aiohttp-client,aiopg,sklearn,system-metrics) according to those packages in the Contrib repo!Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests cover this change
Checklist:
- [] Unit tests have been added- [ ] Documentation has been updated