Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change temporality for Counter and UpDownCounter to CUMULATIVE #1384

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Change temporality for Counter and UpDownCounter to CUMULATIVE #1384

merged 1 commit into from
Nov 18, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 16, 2020 •
edited
Loading

Fixes #1383

Description

Changes temporality for Counter and UpDownCounter to CUMULATIVE.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • test_otlp_metric_exporter.py

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl requested review from a team, codeboten and aabmass and removed request for a team November 16, 2020 23:15
@ocelotl ocelotl self-assigned this Nov 16, 2020
codeboten
codeboten approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some lint failures, otherwise this LGTM

@aabmass
Copy link
Member

aabmass commented Nov 17, 2020

I left a comment on the issue, but I believe this should be derived from stateful.

aabmass
aabmass approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related #1007

@codeboten codeboten merged commit bcf7a2f into open-telemetry:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Counter and UpDownCounter temporality should be CUMULATIVE
4 participants
@ocelotl @aabmass @codeboten @jmacd